I've dived in Hurghada many times and it's great. I can even recommend you a crew to go out with even if Just snorkeling. The only caveat I would mention is if you go off season everything is closed and you'll be hard pressed to find anywhere outside your hotel to eat or drink. We'll anywhere that's decent anyway.
Edit, most excursions will supply all your snorkeling gear too. If you just want to go snorkeling off the beach just choose your hotel carefully for the best locations for reef, sea life.